forked from Mirantis/hmc
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Adding sevriceTemplates to ManagedCluster #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wahabmk
force-pushed
the
reconcile-servicetemplates
branch
13 times, most recently
from
September 23, 2024 16:15
01a018f
to
30c73ee
Compare
Handle TemplateManagement creation and removal
wahabmk
force-pushed
the
reconcile-servicetemplates
branch
3 times, most recently
from
September 25, 2024 11:16
ae51ffc
to
2bd0085
Compare
Fix incorrect condition to enable CAPI
Add CODEOWNERS
wahabmk
force-pushed
the
reconcile-servicetemplates
branch
from
September 26, 2024 14:27
2bd0085
to
3ffa70f
Compare
Bumps [github.com/fluxcd/source-controller/api](https://github.com/fluxcd/source-controller) from 1.3.0 to 1.4.1. - [Release notes](https://github.com/fluxcd/source-controller/releases) - [Changelog](https://github.com/fluxcd/source-controller/blob/main/CHANGELOG.md) - [Commits](fluxcd/source-controller@v1.3.0...v1.4.1) --- updated-dependencies: - dependency-name: github.com/fluxcd/source-controller/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Implemented Azure e2e tests
…ithub.com/fluxcd/source-controller/api-1.4.1 Bump github.com/fluxcd/source-controller/api from 1.3.0 to 1.4.1
Add Credential CR and controller
Bumps [github.com/fluxcd/helm-controller/api](https://github.com/fluxcd/helm-controller) from 1.0.1 to 1.1.0. - [Release notes](https://github.com/fluxcd/helm-controller/releases) - [Changelog](https://github.com/fluxcd/helm-controller/blob/main/CHANGELOG.md) - [Commits](fluxcd/helm-controller@v1.0.1...v1.1.0) --- updated-dependencies: - dependency-name: github.com/fluxcd/helm-controller/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
* removed/unexported a couple of variables being not used as exported * decreased cognitive burden removing redundant fields/smell patterns * a couple of comments to reflect on the public API
…ithub.com/fluxcd/helm-controller/api-1.1.0 Bump github.com/fluxcd/helm-controller/api from 1.0.1 to 1.1.0
Chores with human linter
Fix CP providers label in charts meta
wahabmk
force-pushed
the
reconcile-servicetemplates
branch
2 times, most recently
from
September 30, 2024 15:24
b00ae13
to
4e0f8c0
Compare
wahabmk
force-pushed
the
reconcile-servicetemplates
branch
from
September 30, 2024 15:31
4e0f8c0
to
dadff0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
ManagedCluster
object, where each service corresponds to aServiceTemplate
.ClusterProfile
object.ManagedCluster
object. That will be done in a follow-up PR while working on https://github.com/Mirantis/hmc/issues/ 361.Testing
make dev-apply && make dev-creds-apply
and waited for everything to be running.make dev-mcluster-apply
and waited for everything to be running.Provisioning
On Management Cluster
We can see the
ClusterProfile
object was created withkyverno
andingress-nginx
services:We can see the associated
ClusterSummary
object was also created and reports that the services have been "Provisioned" onto the target cluster:On Target Cluster
We can see both
kyverno
andingress-nginx
running on the target cluster:Setting
install=false
for ingress-nginx (scroll horizontally)By setting
install=false
on theManagedCluster
object, theingress-nginx
service was removed fromClusterProfile
->ClusterSummary
objects:We can see
ingress-nginx
was installed from target cluster.Making
services
list emptyWe see that the
ClusterSummary
object does not show anyhelmCharts
list:As expected, we can see that both
ingress-nginx
andkyverno
have been uninstalled from the target cluster:➜ ~ kubectl get pod -A NAMESPACE NAME READY STATUS RESTARTS AGE kube-system aws-cloud-controller-manager-fjfg2 1/1 Running 0 15m kube-system calico-kube-controllers-695f6448bd-fckbc 1/1 Running 0 16m kube-system calico-node-7tv5t 1/1 Running 0 15m kube-system calico-node-wkxvg 1/1 Running 0 13m kube-system coredns-6997b8f8bd-f966x 1/1 Running 0 13m kube-system coredns-6997b8f8bd-ht4qs 1/1 Running 0 13m kube-system ebs-csi-controller-5c9db44f4f-5cs6w 5/5 Running 0 15m kube-system ebs-csi-controller-5c9db44f4f-6twcq 5/5 Running 0 15m kube-system ebs-csi-node-ctcfp 3/3 Running 0 15m kube-system ebs-csi-node-mh8w2 3/3 Running 0 13m kube-system kube-proxy-gsw28 1/1 Running 0 15m kube-system kube-proxy-wkz7d 1/1 Running 0 13m kube-system metrics-server-7cc78958fc-n6jrp 1/1 Running 0 16m projectsveltos sveltos-agent-manager-67d6ffbd86-5vx9z 1/1 Running 0 15m
Re-enabling both services again
We see that the
ClusterSummary
object again shows the list ofhelmCharts
:Both
ingress-nginx
andkyverno
have again been installed on the target cluster:➜ ~ kubectl get pod -A NAMESPACE NAME READY STATUS RESTARTS AGE ingress-nginx ingress-nginx-controller-5bfc858768-dmt84 1/1 Running 0 55s kube-system aws-cloud-controller-manager-fjfg2 1/1 Running 0 18m kube-system calico-kube-controllers-695f6448bd-fckbc 1/1 Running 0 19m kube-system calico-node-7tv5t 1/1 Running 0 18m kube-system calico-node-wkxvg 1/1 Running 0 17m kube-system coredns-6997b8f8bd-f966x 1/1 Running 0 16m kube-system coredns-6997b8f8bd-ht4qs 1/1 Running 0 16m kube-system ebs-csi-controller-5c9db44f4f-5cs6w 5/5 Running 0 19m kube-system ebs-csi-controller-5c9db44f4f-6twcq 5/5 Running 0 19m kube-system ebs-csi-node-ctcfp 3/3 Running 0 18m kube-system ebs-csi-node-mh8w2 3/3 Running 0 17m kube-system kube-proxy-gsw28 1/1 Running 0 18m kube-system kube-proxy-wkz7d 1/1 Running 0 17m kube-system metrics-server-7cc78958fc-n6jrp 1/1 Running 0 19m kyverno kyverno-admission-controller-776987899-qw8g6 1/1 Running 0 67s kyverno kyverno-background-controller-86b9f95c96-8nmt5 1/1 Running 0 67s kyverno kyverno-cleanup-controller-7bbfc97569-zg86g 1/1 Running 0 67s kyverno kyverno-reports-controller-665ccb5b65-jg4xb 1/1 Running 0 67s projectsveltos sveltos-agent-manager-67d6ffbd86-5vx9z 1/1 Running 0 19m
Finally deleting the
ManagedCluster
objectWait for a while for the delete to finish . . .
We can see that that the associated
ClusterProfile
andClusterSummary
objects have also been deleted: